Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cli support for Apache Kafka native ACLs #393

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Add cli support for Apache Kafka native ACLs #393

merged 1 commit into from
Nov 29, 2024

Conversation

biggusdonzus
Copy link
Contributor

@biggusdonzus biggusdonzus commented Nov 18, 2024 •
edited
Loading

Add the following service subcomands kafka-acl-list kafka-acl-add kafka-acl-delete.

@biggusdonzus biggusdonzus force-pushed the fdorlandi-add-support-for-kafka-acls branch 2 times, most recently from 19601e5 to d822e79 Compare November 19, 2024 15:30
tvainika
tvainika reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@tvainika tvainika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition existing Aiven ACLs for Kafka need doc polishing to make it clear what is where (use avn service --help to see those existing commands)

aiven/client/cli.py Outdated Show resolved Hide resolved
aiven/client/cli.py Outdated Show resolved Hide resolved
aiven/client/cli.py Outdated Show resolved Hide resolved
aiven/client/cli.py Outdated Show resolved Hide resolved
aiven/client/cli.py Outdated Show resolved Hide resolved
aiven/client/cli.py Outdated Show resolved Hide resolved
tvainika
tvainika reviewed Nov 20, 2024
View reviewed changes
aiven/client/cli.py Outdated Show resolved Hide resolved
tvainika
tvainika reviewed Nov 20, 2024
View reviewed changes
aiven/client/cli.py Outdated Show resolved Hide resolved
@biggusdonzus biggusdonzus force-pushed the fdorlandi-add-support-for-kafka-acls branch 3 times, most recently from 456b98a to b51e5ad Compare November 22, 2024 11:11
@biggusdonzus biggusdonzus marked this pull request as ready for review November 22, 2024 11:58
@biggusdonzus biggusdonzus requested review from a team as code owners November 22, 2024 11:58
@biggusdonzus biggusdonzus force-pushed the fdorlandi-add-support-for-kafka-acls branch from b51e5ad to bf4e0fd Compare November 22, 2024 14:24
@tvainika tvainika merged commit 61dee44 into main Nov 29, 2024
26 checks passed
@tvainika tvainika deleted the fdorlandi-add-support-for-kafka-acls branch November 29, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvainika tvainika tvainika approved these changes

@bhammerich-aiven bhammerich-aiven Awaiting requested review from bhammerich-aiven bhammerich-aiven is a code owner automatically assigned from aiven/team-andromeda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biggusdonzus @tvainika